WillAyd opened a new pull request, #41107:
URL: https://github.com/apache/arrow/pull/41107
Though the original issue was closed, I am also seeing this warning when
compiling nanoarrow
```
[13/91] Compiling C++ object src/nanoarrow/utils_test.p/utils_test.cc.o
FAILED: src/nanoarrow/utils_test.p/utils_test.cc.o
c++ -Isrc/nanoarrow/utils_test.p -Isrc/nanoarrow -I../src/nanoarrow -Isrc
-I../src -I/home/arrow-nanoarrow/arrow/include -fdiagnostics-color=always
-D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra
-Werror -std=c++17 -O3 -pthread
-isystem../subprojects/googletest-1.14.0/googletest
-isystemsubprojects/googletest-1.14.0/googletest
-isystem../subprojects/googletest-1.14.0/googletest/include -MD -MQ
src/nanoarrow/utils_test.p/utils_test.cc.o -MF
src/nanoarrow/utils_test.p/utils_test.cc.o.d -o
src/nanoarrow/utils_test.p/utils_test.cc.o -c ../src/nanoarrow/utils_test.cc
In file included from ../src/nanoarrow/utils_test.cc:21:
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h: In member function
‘arrow::Result<std::pair<arrow::Decimal128, arrow::Decimal128> >
arrow::Decimal128::Divide(const arrow::Decimal128&) const’:
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:83:21: error:
redundant move in return statement [-Werror=redundant-move]
83 | return std::move(result);
| ~~~~~~~~~^~~~~~~~
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:83:21: note: remove
‘std::move’ call
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h: In member function
‘arrow::Result<arrow::Decimal128> arrow::Decimal128::Rescale(int32_t, int32_t)
const’:
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:121:21: error:
redundant move in return statement [-Werror=redundant-move]
121 | return std::move(out);
| ~~~~~~~~~^~~~~
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:121:21: note:
remove ‘std::move’ call
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h: In member function
‘arrow::Result<arrow::Decimal256> arrow::Decimal256::Rescale(int32_t, int32_t)
const’:
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:221:21: error:
redundant move in return statement [-Werror=redundant-move]
221 | return std::move(out);
| ~~~~~~~~~^~~~~
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:221:21: note:
remove ‘std::move’ call
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h: In member function
‘arrow::Result<std::pair<arrow::Decimal256, arrow::Decimal256> >
arrow::Decimal256::Divide(const arrow::Decimal256&) const’:
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:238:21: error:
redundant move in return statement [-Werror=redundant-move]
238 | return std::move(result);
| ~~~~~~~~~^~~~~~~~
/home/arrow-nanoarrow/arrow/include/arrow/util/decimal.h:238:21: note:
remove ‘std::move’ call
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
