alamb commented on code in PR #5619:
URL: https://github.com/apache/arrow-rs/pull/5619#discussion_r1558181390
##########
arrow-data/src/transform/mod.rs:
##########
@@ -178,13 +178,14 @@ fn build_extend_view(array: &ArrayData, buffer_offset:
u32) -> Extend {
mutable
.buffer1
.extend(views[start..start + len].iter().map(|v| {
- let len = *v as u32;
- if len <= 12 {
- return *v; // Stored inline
- }
- let mut view = ByteView::from(*v);
- view.buffer_index += buffer_offset;
- view.into()
+ let new_view: u128 = match View::from(*v) {
Review Comment:
Likewise this seems to me to be a clearer representation of what is going on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
