kou commented on code in PR #41111:
URL: https://github.com/apache/arrow/pull/41111#discussion_r1558561042
##########
cpp/src/arrow/array/builder_base.h:
##########
@@ -177,6 +177,9 @@ class ARROW_EXPORT ArrayBuilder {
/// The given array must be the same type as the builder.
virtual Status AppendArraySlice(const ArraySpan& array, int64_t offset,
int64_t length) {
+ ARROW_UNUSED(array);
+ ARROW_UNUSED(offset);
+ ARROW_UNUSED(length);
Review Comment:
How about using `ARROW_ARG_UNUSED()` instead?
```suggestion
virtual Status AppendArraySlice(const ArraySpan& ARROW_ARG_UNUSED(array),
int64_t ARROW_ARG_UNUSED(offset),
int64_t ARROW_ARG_UNUSED(length)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
