paleolimbot commented on PR #421: URL: https://github.com/apache/arrow-nanoarrow/pull/421#issuecomment-2046306239
Jinx! I spent some time earlier today on this too (#420) and fixed at least some of these, inspired by giving your Meson build a spin (which I think compiles the tests with more warning flags). I'm sorry to have overlapped so much with this PR! > any objection to updating the current CMake jobs? Or maybe we can add one for meson to run on every PR? We could do either...the CMake defines quite a lot of warning flags that run on the `nanoarrow` and `nanoarrow_ipc` targets. We could generalize that a little so that it's easier to specify those warning flags for more targets (maybe using a CMake interface target or by keeping a list of targets and then looping over the targets and setting warning flags). We could also add `-Werror` to the Meson build (I assume there's a way to do this?) and see how often that is a problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
