hiltontj commented on code in PR #5622:
URL: https://github.com/apache/arrow-rs/pull/5622#discussion_r1559426323
##########
arrow-json/Cargo.toml:
##########
@@ -56,6 +56,7 @@ tokio = { version = "1.27", default-features = false,
features = ["io-util"] }
bytes = "1.4"
criterion = { version = "0.5", default-features = false }
rand = { version = "0.8", default-features = false, features = ["std",
"std_rng"] }
+hex = "0.4.3"
Review Comment:
I updated the test so that it no longer relies on the `hex` crate, and
removed the dep. I think it would be nice to have a test that fully round-trips
data, first by decoding from HEX to the `FixedSizeBinary`, then encoding back.
But, I am not sure if we want to support this behaviour on the JSON reader, and
this issue is only about the write side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
