sergiimk opened a new pull request, #10033:
URL: https://github.com/apache/arrow-datafusion/pull/10033
**NOTE:** This PR is only a conversation starter for stack overflow issues
like #9893 and several similar issues linked on that ticket.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #9893.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The intent is to:
- Identify places likely to cause stack overflows using clippy pedantic lint
- Show one of the key contributors to the problem: `DataFrame::session_state`
- Demonstrate a hacky solution that solves clippy warnings and stack
overflows
- Discuss what a proper fix should look like
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
1) Enables
[`clippy::pedantic::large_futures`](https://rust-lang.github.io/rust-clippy/master/index.html#/large_future)
lint
- This highlights a number of places in code where futures exceed 20KiB on
stack
- I think this lint is very useful and propose to merge it
- It provides a foundation to easily enable more lints going further on
the workspace level
2) Traces the large allocations to `DataFrame` and shows a simple boxing
approach as the smallest change that mitigates the problem.
- Before this change:
- `size_of<SessionState>: 1648`
- `size_of<DataFrame>: 2064`
- After this change:
- `size_of<DataFrame>: 424`
Because `DataFrame`s are intended to be on stack and moved so often - I
think 2K (and even 420 bytes) is too big of a size for this object.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
TBD
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
