sgilmore10 opened a new pull request, #41131:
URL: https://github.com/apache/arrow/pull/41131

   
   ### Rationale for this change
   
   As per @kou's 
[suggestion](https://github.com/apache/arrow/pull/40956#discussion_r1556447060) 
in #40956, we should create unique git tags (e.g. 
`apache-arrow-{MAJOR}.{MINOR}.{VERSION}-rc{RC_NUM}`) instead re-using the same 
git tag (`apache-arrow-{MAJOR}.{MINOR}.{VERSION}`) for each release candidate. 
The official release candidate tag (`apache-arrow-{MAJOR}.{MINOR}.{VERSION}`) 
should be created **only** after a release candidate is voted on and accepted. 
This "official" release tag should point to the same object in the git database 
as the accepted release candidate tag. 
   
   The new release workflow could look like the following:
   
   > 1. Create a apache-arrow-X.Y.Z-rc0 tag for X.Y.Z RC0 
   > 2. (Found a problem for X.Y.Z RC0)
   > 3. Create a apache-arrow-X.Y.Z-rc1 tag for X.Y.Z RC1
   > 4. Vote
   > 5. Passed
   > 6. Create a apache-arrow-X.Y.Z tag from apache-arrow-X.Y.Z-rc1 ike 
apache/arrow-adbc and apache/arrow-flight-sql-postgresql do
   
   See @kou's 
[comment](https://github.com/apache/arrow/pull/40956#discussion_r1556447060) 
for more details.
   
   ### What changes are included in this PR?
   
   1. Updated `dev/release/01-prepare.sh` to create release-candidate-specific 
git tags (e.g. `apache-arrow-{MAJOR}.{MINOR}.{PATCH}-rc{RC_NUM}`).
   2. Updated scripts in `dev/release` to use the new git tag name. 
   3. Added GitHub Workflow file  `publish_release_candidate.yml`. This 
workflow is triggered when a release candidate git tag is pushed and creates a 
Prerelease GitHub Release.
   4. Added logic to `dev/release/02-post-binary.sh` to create and push the 
release git tag (i.e. `apache-arrow-{MAJOR}.{MINOR}.{PATCH}`).
   5. Added GitHub Workflow `publish_release.yml`. This workflow is triggered 
when the release tag is pushed and creates a GitHub Release for the approved 
release (i.e. the voted upon release).
   6. Added `dev/release/post-16-delete-release-candidates.sh` to delete the 
release candidate git tags and their associated GitHub Releases. 
   7. Updated `docs/developers/release.rst` with the new steps. 
   
   ### Are these changes tested?
   
   1. We were not able to verify the changes made to the scripts in 
`dev/release`. Any suggestions on how we can verify these scripts would be much 
appreciated :)
   2. We did test the new GitHub Workflows (`publish_release_candidate.yml` and 
`publish_release.yml`) work as intended by pushing git tags to 
[`mathworks/arrow`](https://github.com/mathworks/arrow).
   
   
   ### Are there any user-facing changes?
   
   No.
   
   ### Open Questions
   
   1. We noticed that 
[apache/arrow-flight-sql-postgresql](https://github.com/apache/arrow-flight-sql-postgresql/releases)
 does **not** delete the release candidate Prereleases from their GitHub 
Releases area. Should we be doing the same? Or would it be preferable to just 
delete the the release candidates **without** deleting the release candidate 
tags.
   2. We're not that familiar with ruby, so we're not sure if the changes we 
made to `dev/release/02-source-test.rb` make sense.
   
   
   ### Future Directions
   
   1.  Continue working on #40956
   2. Add logic to auto-sign release artifacts in GitHub Actions Workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to