alamb commented on code in PR #10016:
URL:
https://github.com/apache/arrow-datafusion/pull/10016#discussion_r1557811073
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1528,25 +1533,35 @@ impl LogicalPlan {
///
/// See [`Self::with_param_values`] for examples and usage
pub fn replace_params_with_values(
- &self,
+ self,
Review Comment:
Removing the `&` is the API change -- this allows avoiding a clone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
