alamb commented on code in PR #9954:
URL: https://github.com/apache/arrow-datafusion/pull/9954#discussion_r1560787046
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -80,12 +84,31 @@ pub trait OptimizerRule {
/// A human readable name for this optimizer rule
fn name(&self) -> &str;
- /// How should the rule be applied by the optimizer? See comments on
[`ApplyOrder`] for details.
+ /// How should the rule be applied by the optimizer? See comments on
+ /// [`ApplyOrder`] for details.
///
- /// If a rule use default None, it should traverse recursively plan inside
itself
+ /// If returns `None`, the default, the rule must handle recursion itself
fn apply_order(&self) -> Option<ApplyOrder> {
None
Review Comment:
I agree most of the cases probably *should be* bottom up (but not all). I'll
keep an eye open for this as I work through the other optimizer rules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
