pitrou commented on code in PR #37821:
URL: https://github.com/apache/arrow/pull/37821#discussion_r1560921349
##########
ci/docker/ubuntu-22.04-cpp.dockerfile:
##########
@@ -115,10 +116,20 @@ RUN apt-get update -y -q && \
rapidjson-dev \
rsync \
tzdata \
- wget && \
+ wget \
+ xz-utils && \
apt-get clean && \
rm -rf /var/lib/apt/lists*
+# install emscripten using EMSDK
+ARG emscripten_version="3.1.45"
+RUN cd ~ && git clone https://github.com/emscripten-core/emsdk.git && \
Review Comment:
Hmm, two things:
1. it would have been better for resource usage to make a separate
dockerfile for this, perhaps
2. could this be a script to avoid having tons of hand-coded bash code in
dockerfiles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
