alamb commented on PR #10026: URL: https://github.com/apache/arrow-datafusion/pull/10026#issuecomment-2049764135
Benchmark results. The only one that looks potentially problematic is clickbench 28 -- I'll rerun and see if I can reproduce the results ``` │ QQuery 28 │ 27356.53ms │ 30720.69ms │ 1.12x slower │ ``` ``` -------------------- Benchmark tpch_mem.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ crepererum_fix_locking_2 ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 208.16ms │ 202.92ms │ no change │ │ QQuery 2 │ 39.25ms │ 41.98ms │ 1.07x slower │ │ QQuery 3 │ 61.22ms │ 62.78ms │ no change │ │ QQuery 4 │ 61.86ms │ 59.45ms │ no change │ │ QQuery 5 │ 97.23ms │ 94.53ms │ no change │ │ QQuery 6 │ 15.03ms │ 14.61ms │ no change │ │ QQuery 7 │ 194.63ms │ 200.19ms │ no change │ │ QQuery 8 │ 42.67ms │ 41.67ms │ no change │ │ QQuery 9 │ 112.37ms │ 109.34ms │ no change │ │ QQuery 10 │ 105.84ms │ 102.00ms │ no change │ │ QQuery 11 │ 35.28ms │ 35.14ms │ no change │ │ QQuery 12 │ 49.17ms │ 47.43ms │ no change │ │ QQuery 13 │ 80.66ms │ 76.34ms │ +1.06x faster │ │ QQuery 14 │ 19.90ms │ 20.74ms │ no change │ │ QQuery 15 │ 33.05ms │ 33.46ms │ no change │ │ QQuery 16 │ 42.43ms │ 40.60ms │ no change │ │ QQuery 17 │ 153.25ms │ 152.00ms │ no change │ │ QQuery 18 │ 435.15ms │ 427.61ms │ no change │ │ QQuery 19 │ 51.48ms │ 49.68ms │ no change │ │ QQuery 20 │ 91.23ms │ 95.71ms │ no change │ │ QQuery 21 │ 278.06ms │ 263.75ms │ +1.05x faster │ │ QQuery 22 │ 28.81ms │ 29.54ms │ no change │ └──────────────┴───────────┴──────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 2236.74ms │ │ Total Time (crepererum_fix_locking_2) │ 2201.51ms │ │ Average Time (main_base) │ 101.67ms │ │ Average Time (crepererum_fix_locking_2) │ 100.07ms │ │ Queries Faster │ 2 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 19 │ └─────────────────────────────────────────┴───────────┘ -------------------- Benchmark tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ crepererum_fix_locking_2 ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 1 │ 329.78ms │ 341.28ms │ no change │ │ QQuery 2 │ 128.45ms │ 129.32ms │ no change │ │ QQuery 3 │ 158.71ms │ 167.35ms │ 1.05x slower │ │ QQuery 4 │ 96.10ms │ 101.48ms │ 1.06x slower │ │ QQuery 5 │ 195.68ms │ 196.14ms │ no change │ │ QQuery 6 │ 87.22ms │ 91.13ms │ no change │ │ QQuery 7 │ 276.19ms │ 283.92ms │ no change │ │ QQuery 8 │ 202.38ms │ 209.16ms │ no change │ │ QQuery 9 │ 314.49ms │ 323.30ms │ no change │ │ QQuery 10 │ 265.75ms │ 274.15ms │ no change │ │ QQuery 11 │ 111.10ms │ 113.51ms │ no change │ │ QQuery 12 │ 149.44ms │ 150.26ms │ no change │ │ QQuery 13 │ 315.74ms │ 326.79ms │ no change │ │ QQuery 14 │ 119.72ms │ 128.31ms │ 1.07x slower │ │ QQuery 15 │ 168.98ms │ 182.46ms │ 1.08x slower │ │ QQuery 16 │ 102.12ms │ 105.52ms │ no change │ │ QQuery 17 │ 297.66ms │ 311.36ms │ no change │ │ QQuery 18 │ 411.50ms │ 414.46ms │ no change │ │ QQuery 19 │ 193.98ms │ 201.26ms │ no change │ │ QQuery 20 │ 182.63ms │ 201.86ms │ 1.11x slower │ │ QQuery 21 │ 339.35ms │ 337.28ms │ no change │ │ QQuery 22 │ 78.99ms │ 82.41ms │ no change │ └──────────────┴───────────┴──────────────────────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 4525.96ms │ │ Total Time (crepererum_fix_locking_2) │ 4672.71ms │ │ Average Time (main_base) │ 205.73ms │ │ Average Time (crepererum_fix_locking_2) │ 212.40ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 5 │ │ Queries with No Change │ 17 │ └─────────────────────────────────────────┴───────────┘ -------------------- Benchmark clickbench_extended.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ crepererum_fix_locking_2 ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ QQuery 0 │ 3518.76ms │ 3464.59ms │ no change │ │ QQuery 1 │ 1359.44ms │ 1318.98ms │ no change │ │ QQuery 2 │ 2765.57ms │ 2793.54ms │ no change │ └──────────────┴───────────┴──────────────────────────┴───────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 7643.77ms │ │ Total Time (crepererum_fix_locking_2) │ 7577.11ms │ │ Average Time (main_base) │ 2547.92ms │ │ Average Time (crepererum_fix_locking_2) │ 2525.70ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 3 │ └─────────────────────────────────────────┴───────────┘ -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ crepererum_fix_locking_2 ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.88ms │ 0.91ms │ no change │ │ QQuery 1 │ 89.09ms │ 91.25ms │ no change │ │ QQuery 2 │ 199.69ms │ 197.63ms │ no change │ │ QQuery 3 │ 194.73ms │ 203.30ms │ no change │ │ QQuery 4 │ 2093.75ms │ 2062.80ms │ no change │ │ QQuery 5 │ 1952.25ms │ 1902.11ms │ no change │ │ QQuery 6 │ 82.19ms │ 78.71ms │ no change │ │ QQuery 7 │ 92.88ms │ 94.01ms │ no change │ │ QQuery 8 │ 3074.62ms │ 3178.68ms │ no change │ │ QQuery 9 │ 2327.77ms │ 2308.59ms │ no change │ │ QQuery 10 │ 780.46ms │ 796.81ms │ no change │ │ QQuery 11 │ 848.76ms │ 864.63ms │ no change │ │ QQuery 12 │ 2048.46ms │ 2035.28ms │ no change │ │ QQuery 13 │ 4364.39ms │ 4289.92ms │ no change │ │ QQuery 14 │ 2719.47ms │ 2743.64ms │ no change │ │ QQuery 15 │ 2354.00ms │ 2321.72ms │ no change │ │ QQuery 16 │ 5522.06ms │ 5530.26ms │ no change │ │ QQuery 17 │ 5463.80ms │ 5494.81ms │ no change │ │ QQuery 18 │ 11140.18ms │ 10973.02ms │ no change │ │ QQuery 19 │ 161.06ms │ 164.70ms │ no change │ │ QQuery 20 │ 2609.20ms │ 2589.19ms │ no change │ │ QQuery 21 │ 3326.62ms │ 3326.95ms │ no change │ │ QQuery 22 │ 9043.88ms │ 9020.46ms │ no change │ │ QQuery 23 │ 20855.10ms │ 20686.94ms │ no change │ │ QQuery 24 │ 1329.66ms │ 1297.87ms │ no change │ │ QQuery 25 │ 1132.55ms │ 1117.24ms │ no change │ │ QQuery 26 │ 1453.63ms │ 1418.42ms │ no change │ │ QQuery 27 │ 3845.14ms │ 3758.03ms │ no change │ │ QQuery 28 │ 27356.53ms │ 30720.69ms │ 1.12x slower │ │ QQuery 29 │ 1082.37ms │ 1059.70ms │ no change │ │ QQuery 30 │ 2415.60ms │ 2330.50ms │ no change │ │ QQuery 31 │ 3102.71ms │ 3013.29ms │ no change │ │ QQuery 32 │ 15520.66ms │ 15396.94ms │ no change │ │ QQuery 33 │ 8968.94ms │ 8908.69ms │ no change │ │ QQuery 34 │ 13112.15ms │ 13167.68ms │ no change │ │ QQuery 35 │ 3807.04ms │ 3731.88ms │ no change │ │ QQuery 36 │ 338.47ms │ 334.33ms │ no change │ │ QQuery 37 │ 226.46ms │ 229.11ms │ no change │ │ QQuery 38 │ 190.78ms │ 188.71ms │ no change │ │ QQuery 39 │ 1103.90ms │ 1091.60ms │ no change │ │ QQuery 40 │ 91.35ms │ 90.12ms │ no change │ │ QQuery 41 │ 83.58ms │ 82.36ms │ no change │ │ QQuery 42 │ 98.58ms │ 98.17ms │ no change │ └──────────────┴────────────┴──────────────────────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩ │ Total Time (main_base) │ 166605.39ms │ │ Total Time (crepererum_fix_locking_2) │ 168991.63ms │ │ Average Time (main_base) │ 3874.54ms │ │ Average Time (crepererum_fix_locking_2) │ 3930.04ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 42 │ └─────────────────────────────────────────┴─────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
