pitrou commented on code in PR #41155:
URL: https://github.com/apache/arrow/pull/41155#discussion_r1561303053
##########
cpp/src/arrow/util/value_parsing.cc:
##########
@@ -53,8 +53,11 @@ bool StringToFloat(const char* s, size_t length, char
decimal_point, uint16_t* o
float temp_out;
const auto res =
::arrow_vendored::fast_float::from_chars_advanced(s, s + length,
temp_out, options);
- *out = Float16::FromFloat(temp_out).bits();
- return res.ec == std::errc() && res.ptr == s + length;
+ const bool ok = res.ec == std::errc() && res.ptr == s + length;
Review Comment:
No, it's just that otherwise the result is a failure and there is no need to
do the final conversion to float16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
