zeroshade commented on code in PR #38385:
URL: https://github.com/apache/arrow/pull/38385#discussion_r1561592975
##########
go/arrow/flight/flightsql/types.go:
##########
@@ -854,3 +880,19 @@ const (
)
type CreatePreparedStatementResult = pb.ActionCreatePreparedStatementResult
+
+type TableDefinitionOptions = pb.CommandStatementIngest_TableDefinitionOptions
+
+type TableDefinitionOptionsTableNotExistOption =
pb.CommandStatementIngest_TableDefinitionOptions_TableNotExistOption
+type TableDefinitionOptionsTableExistsOption =
pb.CommandStatementIngest_TableDefinitionOptions_TableExistsOption
Review Comment:
for clarity should we gather these into a single declaration block?
```suggestion
type (
CreatePreparedStatementResult =
pb.ActionCreatePreparedStatementResult
TableDefinitionOptions =
pb.CommandStatementIngest_TableDefinitionOptions
TableDefinitionOptionsTableNotExistOption =
pb.CommandStatementIngest_TableDefinitionOptions_TableNotExistOption
TableDefinitionOptionsTableExistsOption =
pb.CommandStatementIngest_TableDefinitionOptions_TableExistsOption
)
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
