ianmcook commented on pull request #9287: URL: https://github.com/apache/arrow/pull/9287#issuecomment-780045754
@kszucs My latest commits in this PR fix the unintended side effects that were occurring because of the addition of the manifest file `cpp/vcpkg.json`: - The Python wheel builds (which use vcpkg to install dependencies but are _not_ supposed to use the manifest) were failing, because the existence of the manifest was causing the Visual Studio CMake toolchain to behave in some unexpected ways. I have set several variables and options that resolve this. - When a developer opened the `cpp` directory in the Visual Studio 2019 IDE, it would automatically recognize the manifest and initiate a `vcpkg install` regardless of whether the developer intended to use vcpkg to install dependencies. I added a `CMakeSettings.json` file to disable this behavior. The **wheel-manylinux2010-cp36m** and **wheel-windows-cp36m** Crossbow builds are now passing The **test-build-vcpkg-win** failure is for the same reasons as noted above in https://github.com/apache/arrow/pull/9287#issuecomment-769843489 and should not block this from being merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
