alamb commented on code in PR #5632:
URL: https://github.com/apache/arrow-rs/pull/5632#discussion_r1562781049
##########
arrow/src/ffi.rs:
##########
@@ -1176,4 +1181,36 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_run_array() -> Result<()> {
+ let value_data =
Review Comment:
Can you please add a test with a nullable array as well? (as in make a test
that has `value_data` with NULLs in it)
##########
arrow-schema/src/ffi.rs:
##########
@@ -681,6 +693,7 @@ fn get_format_string(dtype: &DataType) -> Result<String,
ArrowError> {
DataType::LargeList(_) => Ok("+L".to_string()),
DataType::Struct(_) => Ok("+s".to_string()),
DataType::Map(_, _) => Ok("+m".to_string()),
+ DataType::RunEndEncoded(_, _) => Ok("+r".to_string()),
Review Comment:
I verified `+r` is the correct format:
https://arrow.apache.org/docs/format/CDataInterface.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
