DuanWeiFan commented on PR #41160: URL: https://github.com/apache/arrow/pull/41160#issuecomment-2052078394
thanks for checking @zeroshade Yeah I just added the benchmark for the method to the pr. And here's the Benchmark Test Before vs After code change ``` --- Before goos: darwin goarch: amd64 pkg: github.com/apache/arrow/go/v15/parquet/internal/utils cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkBitWriter BenchmarkBitWriter-12 40391650 28.91 ns/op 17 B/op 1 allocs/op PASS ok github.com/apache/arrow/go/v15/parquet/internal/utils 3.107s --- After goos: darwin goarch: amd64 pkg: github.com/apache/arrow/go/v15/parquet/internal/utils cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkBitWriter BenchmarkBitWriter-12 107185990 9.702 ns/op 1 B/op 0 allocs/op PASS ok github.com/apache/arrow/go/v15/parquet/internal/utils 3.111s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
