devinjdangelo commented on code in PR #10065:
URL:
https://github.com/apache/arrow-datafusion/pull/10065#discussion_r1563271216
##########
datafusion/physical-plan/src/insert.rs:
##########
@@ -74,10 +74,14 @@ pub trait DataSink: DisplayAs + Debug + Send + Sync {
) -> Result<u64>;
}
+#[allow(dead_code)]
+#[deprecated(since = "38.0.0", note = "Use [`DataSinkExec`] instead")]
+type FileSinkExec = DataSinkExec;
Review Comment:
I think this type alias needs to be marked public to enable downstream code
referencing the old name to continue to work. That should also eliminate the
dead code warning I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
