Ted-Jiang commented on code in PR #10051:
URL:
https://github.com/apache/arrow-datafusion/pull/10051#discussion_r1563946482
##########
datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs:
##########
@@ -548,7 +551,20 @@ impl<'a> PruningStatistics for PagesPruningStatistics<'a> {
}
fn row_counts(&self, _column: &datafusion_common::Column) ->
Option<ArrayRef> {
- None
+ // see
https://github.com/apache/arrow-rs/blob/91f0b1771308609ca27db0fb1d2d49571b3980d8/parquet/src/file/metadata.rs#L979-L982
+ let mut first_row_index = self
+ .col_offset_indexes
Review Comment:
@alamb thanks to your always conscientious review and kindly suggestions .
Avoid allocate in
[b2d3641](https://github.com/apache/arrow-datafusion/pull/10051/commits/b2d3641ba76d84b23cb11cefdf252e551835c000)
In my mind `page_locations ` store the offsets in the column chunk , i
think they are the same meaning 🤣
##########
datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs:
##########
@@ -548,7 +551,20 @@ impl<'a> PruningStatistics for PagesPruningStatistics<'a> {
}
fn row_counts(&self, _column: &datafusion_common::Column) ->
Option<ArrayRef> {
- None
+ // see
https://github.com/apache/arrow-rs/blob/91f0b1771308609ca27db0fb1d2d49571b3980d8/parquet/src/file/metadata.rs#L979-L982
+ let mut first_row_index = self
+ .col_offset_indexes
Review Comment:
@alamb thanks to your always conscientious review and kindly suggestions . 👍
Avoid allocate in
[b2d3641](https://github.com/apache/arrow-datafusion/pull/10051/commits/b2d3641ba76d84b23cb11cefdf252e551835c000)
In my mind `page_locations ` store the offsets in the column chunk , i
think they are the same meaning 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
