huaxingao commented on PR #9991: URL: https://github.com/apache/arrow-datafusion/pull/9991#issuecomment-2053697778
@alamb I am not so sure how to proceed with this PR. Do we still need this PR? For `IGNORE NULLS`, I think we have consensus to error in the parser if aggregates don't support `IGNORE NULLS`. For `ORDER BY`, there are two options: 1. Keep the current behavior, that is, allow `SUM(ORDER BY ...)`. The rationale is: - The DataFusion optimizer would remove the `ORDER BY` if the order doesn't matter. - For float type, the order matters, so we need the `ORDER BY` - Postgres allows the `SUM(ORDER BY ...)`. 2. Error in the parser if ordering doesn't matter (That's what Spark does). So, we will either change the parser or leave the current implementation as is. It seems to me we don't need this PR anymore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
