donraab commented on issue #40896: URL: https://github.com/apache/arrow/issues/40896#issuecomment-2053712197
@martin-traverse @lidavidm Here's a [link](https://github.com/apache/arrow/commit/09d6ca747cb9f247a15268cfd04fa6aeb89c3f12) to the change that I explained in a previous comment may have been lost with this Netty / Eclipse Collections dependency shuffle / removals. There was a values implementation in `MapWithOrdinalImpl` as follows before Netty `IntObjectHashMap` dependency was removed. ``` public Collection<V> values() { return StreamSupport.stream(secondary.entries().spliterator(), false) .map((IntObjectMap.PrimitiveEntry<V> t) -> Preconditions.checkNotNull(t).value()) .collect(Collectors.toList()); } ``` This was replaced with current implementation of `values()` when Eclipse Collections `IntObjectHashMap` was used. Now that Netty `IntObjectHashMap` has returned as a copy in the same package, I suggest again making sure this code which was changed works as is currently implemented. I do not have any understanding of why the specialized values code was necessary before (or if it is not), but am simply noting a diff that occurred with these changes. If it works as is, then great! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
