vibhatha commented on code in PR #40520:
URL: https://github.com/apache/arrow/pull/40520#discussion_r1565260143
##########
dev/archery/archery/linking.py:
##########
@@ -61,9 +63,84 @@ def list_dependency_names(self):
names.append(name)
return names
+ def _extract_symbols(self, symbol_info):
+ return [re.search(r'\S+$', line).group() for line in symbol_info if
line]
+
+ def _remove_weak_symbols(self, symbol_info):
+ return [line for line in symbol_info if not re.search(r'\s[Ww]\s',
line)]
+
+ def _capture_symbols(self, remove_symbol_versions, symbol_info):
+ if remove_symbol_versions:
+ symbol_info = [re.split('@@', line)[0] for line in symbol_info]
+ return symbol_info
+
+ def list_symbols_for_dependency(self, dependency,
remove_symbol_versions=False):
+ if dependency == 'linux-vdso.so.1':
+ return []
+ result = _nm.run('-D', dependency, stdout=subprocess.PIPE)
Review Comment:
Locally things were fine, but the java-jars crossbow is failing with symbols
being detected. Need to check why this is happening?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
