emkornfield commented on a change in pull request #9504:
URL: https://github.com/apache/arrow/pull/9504#discussion_r577359507
##########
File path: cpp/src/arrow/record_batch.cc
##########
@@ -37,6 +37,26 @@
namespace arrow {
+namespace {
+// If there will only be one slice returned it is cheaper to just return the
original
+// RecordBatch (no overhead from vector and std::shared_ptr copying on
underlying arrays).
Review comment:
left over comment from when I was going to down the rabbit whole. I've
moved all this code into the writer.cc to avoid debating the best way to expose
this publicly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
