Kikkon commented on PR #5576: URL: https://github.com/apache/arrow-rs/pull/5576#issuecomment-2056510266
> Sorry for the slow review, I am a little concerned that this PR is very large and appears to copy-pasta a lot of the ListArray code incorrectly. > > Perhaps we might split this up into smaller pieces, something like: > > * Add basic ArrayData construction and validation > * Add ArrayData equality > * Add GenericListViewArray > * Add GenericListViewBuilder > > As it stands it is quite hard to guage what is tested and what isn't, and there are definitely a number of code paths that are simply incorrect @tustvold Sounds good. I'll split it into several smaller pull requests separately. I'll ping you again once I'm ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
