alamb commented on code in PR #10056:
URL:
https://github.com/apache/arrow-datafusion/pull/10056#discussion_r1565585057
##########
datafusion/physical-expr/src/aggregate/approx_percentile_cont.rs:
##########
@@ -284,7 +284,9 @@ impl ApproxPercentileAccumulator {
}
pub(crate) fn merge_digests(&mut self, digests: &[TDigest]) {
- self.digest = TDigest::merge_digests(digests);
+ let mut input_digests = digests.to_vec();
+ input_digests.push(self.digest.clone());
Review Comment:
I think it is possible to avoid these clones -- here is a proposal that
targets this PR https://github.com/Ted-Jiang/arrow-datafusion/pull/118 to do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
