tustvold commented on code in PR #5641:
URL: https://github.com/apache/arrow-rs/pull/5641#discussion_r1565630462
##########
arrow-ipc/src/writer.rs:
##########
@@ -1125,7 +1125,7 @@ fn write_body_buffers<W: Write>(
/// Write a record batch to the writer, writing the message size before the
message
/// if the record batch is being written to a stream
-fn write_continuation<W: Write>(
+pub fn write_continuation<W: Write>(
Review Comment:
This is probably fine but I think the doc comment needs updating
##########
arrow-ipc/src/writer.rs:
##########
@@ -55,10 +55,10 @@ pub struct IpcWriteOptions {
///
/// version 2.0.0: V4, with legacy format enabled
/// version 4.0.0: V5
- metadata_version: crate::MetadataVersion,
+ pub metadata_version: crate::MetadataVersion,
/// Compression, if desired. Will result in a runtime error
/// if the corresponding feature is not enabled
- batch_compression_type: Option<crate::CompressionType>,
+ pub batch_compression_type: Option<crate::CompressionType>,
Review Comment:
We could potentially add accessors for these, but making them public would
limit our ability to make non-breaking changes in future and so I don't think
we can do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
