pitrou commented on code in PR #41202:
URL: https://github.com/apache/arrow/pull/41202#discussion_r1565869364
##########
cpp/src/arrow/flight/integration_tests/test_integration.cc:
##########
@@ -878,16 +879,16 @@ class SessionOptionsScenario : public Scenario {
}
// Update
ARROW_ASSIGN_OR_RAISE(
- auto res3,
- client.SetSessionOptions(
- {}, SetSessionOptionsRequest{
- {{"foolong", std::monostate{}},
- {"big_ol_string_list", "a,b,sea,dee, ,
,geee,(づ｡◕‿‿◕｡)づ"}}}));
+ auto res3, client.SetSessionOptions(
+ {}, SetSessionOptionsRequest{
+ {{"foolong", std::monostate{}},
+ {"big_ol_string_list",
+ std::string("a,b,sea,dee, ,
,geee,(づ｡◕‿‿◕｡)づ")}}}));
ARROW_ASSIGN_OR_RAISE(auto res4, client.GetSessionOptions({}, {}));
if (res4.session_options !=
std::map<std::string, SessionOptionValue>{
{"bardouble", 456.0},
- {"big_ol_string_list", "a,b,sea,dee, , ,geee,(づ｡◕‿‿◕｡)づ"}}) {
+ {"big_ol_string_list", std::string("a,b,sea,dee, ,
,geee,(づ｡◕‿‿◕｡)づ")}}) {
Review Comment:
You're probably missing the "key_with_invalid_value" in line 856 above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
