felipecrv commented on code in PR #41189:
URL: https://github.com/apache/arrow/pull/41189#discussion_r1565883792
##########
cpp/src/arrow/array/builder_nested.cc:
##########
@@ -213,13 +213,13 @@ Status FixedSizeListBuilder::AppendValues(int64_t length,
const uint8_t* valid_b
Status FixedSizeListBuilder::AppendNull() {
RETURN_NOT_OK(Reserve(1));
UnsafeAppendToBitmap(false);
- return value_builder_->AppendNulls(list_size_);
+ return value_builder_->AppendEmptyValues(list_size_);
Review Comment:
More details in the issue https://github.com/apache/arrow/issues/41188
Summary:
When you append nulls you force the creation of a null bitmap for the entire
array.
`[[1, 2], null, [3, 4]]` currently needs a `[1, 0 1]` validity map at the
top-level and a `[1, 1, 0, 0, 1, 1]` map in the child values array when it
could have all values as valid and an empty bitmap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
