tustvold commented on code in PR #5650:
URL: https://github.com/apache/arrow-rs/pull/5650#discussion_r1566294930
##########
object_store/src/aws/client.rs:
##########
@@ -363,8 +362,21 @@ impl S3Client {
)
}
- if let Some(value) = self.config.client_options.get_content_type(path)
{
- builder = builder.header(CONTENT_TYPE, value);
+ let mut has_content_type = false;
Review Comment:
I tried very hard to avoid this getting duplicated in the various
implementations, however, it became very hard to devise something that would:
* Allow GCP to always specify a content type
* Generalize to when we support further attributes that will likely diverge
across the implementations (e.g. #4754)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
