jayzhan211 commented on PR #10062: URL: https://github.com/apache/arrow-datafusion/pull/10062#issuecomment-2058129080
> > To support replacing window first/last, there are many issues to be solved. > > I wonder if starting with simpler aggregates (like `approx_distinct`) might be a good idea. They are probably simpler to port and would let us work through some of the details before breaking off the larger more complex ones > > `first_value` / `last_value` are likely the most complex as they are order aware and can be used as aggregates and window functions While I try to deprecate first/last, I found that window function can works with UDAF without additional change. > Including replacing first/last in convert_firsts_last rule, and support sliding accumulator for udaf, and support list instead of NUMERIC signature. The issue I mentioned is part of a need for deprecating first/last, not for window function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
