nealrichardson commented on code in PR #41223:
URL: https://github.com/apache/arrow/pull/41223#discussion_r1567263445
##########
r/tests/testthat/test-dplyr-summarize.R:
##########
@@ -1083,11 +1121,6 @@ test_that("summarise() can handle scalars and literal
values", {
tibble(y = 1L)
)
- expect_identical(
- record_batch(tbl) %>% summarise(y = Expression$scalar(1L)) %>% collect(),
- tibble(y = 1L)
- )
Review Comment:
They're all kinda the same, this one just no longer works because of how the
evaluation changed, and it didn't seem worth trying to support, it's not a
natural thing to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
