alamb commented on code in PR #10080:
URL:
https://github.com/apache/arrow-datafusion/pull/10080#discussion_r1567364048
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -513,6 +558,66 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn s3_object_store_builder_allow_http_error() -> Result<()> {
+ let access_key_id = "fake_access_key_id";
+ let secret_access_key = "fake_secret_access_key";
+ let endpoint = "http://endpoint33";;
+ let location = "s3://bucket/path/file.parquet";
+
+ let table_url = ListingTableUrl::parse(location)?;
+ let scheme = table_url.scheme();
+ let sql = format!(
+ "CREATE EXTERNAL TABLE test STORED AS PARQUET OPTIONS\
+ ('aws.access_key_id' '{access_key_id}', \
+ 'aws.secret_access_key' '{secret_access_key}', \
+ 'aws.endpoint' '{endpoint}'\
+ ) LOCATION '{location}'"
+ );
+
+ let ctx = SessionContext::new();
+ let mut plan = ctx.state().create_logical_plan(&sql).await?;
+
+ if let LogicalPlan::Ddl(DdlStatement::CreateExternalTable(cmd)) = &mut
plan {
+ register_options(&ctx, scheme);
+ let mut table_options =
ctx.state().default_table_options().clone();
+ table_options.alter_with_string_hash_map(&cmd.options)?;
+ let aws_options =
table_options.extensions.get::<AwsOptions>().unwrap();
+ let err = get_s3_object_store_builder(table_url.as_ref(),
aws_options)
+ .await
+ .unwrap_err();
+
+ assert_eq!(err.to_string(), "Invalid or Unsupported Configuration:
Invalid endpoint: http://endpoint33. HTTP is not allowed for S3 endpoints. To
allow HTTP, set 'aws.allow_http' to true");
Review Comment:
I think I added that test below (demonstrate it doesn't error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
