sgilmore10 commented on PR #41131:
URL: https://github.com/apache/arrow/pull/41131#issuecomment-2059510714
Updates:
1. Added `dev/release/08-matlab-upload.sh` as @kou suggested. This script
(1) signs the MLTBX artifacts downloaded from the `crossbow` job and (2)
uploads the artifacts to the release candidate GitHub Release's area.
2. I noticed a small bug in `matlab/tools/packageMatlabInterface.m`.
Specifically, the logic for extracting the version string only works on strings
formatted like `${major}.${minor}.${patch}.dev${num})`. I rewrote this logic to
support extracting the version string from strings formatted like
`${major}.${minor}.${patch}-rc${rc_num}` as well.
3. Modified the name of the MLTBX file generated by
`matlab/tools/packageMatlabInterface.m` to not include the release candidate
number. Instead, the MLTBX file name just includes the version - this is
similar to how the name of the tarball created by
`dev/release/utils-create-release-tarball.sh` does not include the release
candidate number.
Next Steps:
1. I still need to add the logic for signing the release tarball to the
`release_candidate.yml` workflow. Once we hear back from INFRA regarding
https://issues.apache.org/jira/browse/INFRA-25708, I'll submit a followup
ticket requesting a signing key.
2. Given that I added `dev/release/08-matlab-upload.sh` to this PR, I'll
close #40956 as it is now superfluous.
Let me know if you have any questions or comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
