birschick-bq commented on code in PR #1710: URL: https://github.com/apache/arrow-adbc/pull/1710#discussion_r1567782851
########## csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs: ########## @@ -0,0 +1,209 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +using System; +using System.Collections.Generic; +using System.Threading; +using System.Threading.Tasks; +using Apache.Arrow.Ipc; +using Apache.Hive.Service.Rpc.Thrift; +using Thrift.Protocol; +using Thrift.Transport; + +namespace Apache.Arrow.Adbc.Drivers.Apache.Hive2 +{ + public abstract class HiveServer2Connection : AdbcConnection + { + const string userAgent = "AdbcExperimental/0.0"; + + protected TOperationHandle operationHandle; + protected IReadOnlyDictionary<string, string> properties; + internal TTransport transport; + internal TCLIService.Client client; + internal TSessionHandle sessionHandle; + + internal HiveServer2Connection() : this(null) + { + + } + + internal HiveServer2Connection(IReadOnlyDictionary<string, string> properties) + { + this.properties = properties; + } + + public void Open() + { + TProtocol protocol = CreateProtocol(); + this.transport = protocol.Transport; + this.client = new TCLIService.Client(protocol); + + var s0 = this.client.OpenSession(CreateSessionRequest()).Result; + this.sessionHandle = s0.SessionHandle; + } + + protected abstract TProtocol CreateProtocol(); + protected abstract TOpenSessionReq CreateSessionRequest(); + + public override IArrowArrayStream GetObjects(GetObjectsDepth depth, string catalogPattern, string dbSchemaPattern, string tableNamePattern, List<string> tableTypes, string columnNamePattern) + { + Dictionary<string, Dictionary<string, Dictionary<string, List<string>>>> catalogMap = new Dictionary<string, Dictionary<string, Dictionary<string, List<string>>>>(); + if (depth == GetObjectsDepth.All || depth >= GetObjectsDepth.Catalogs) + { + TGetCatalogsReq getCatalogsReq = new TGetCatalogsReq(this.sessionHandle); + } + + if (depth == GetObjectsDepth.All || depth >= GetObjectsDepth.DbSchemas) + { + TGetSchemasReq getSchemasReq = new TGetSchemasReq(this.sessionHandle); + } + + if (depth == GetObjectsDepth.All || depth >= GetObjectsDepth.Tables) + { + TGetTablesReq getTablesReq = new TGetTablesReq(this.sessionHandle); + } + + if (depth == GetObjectsDepth.All) + { + TGetColumnsReq columnsReq = new TGetColumnsReq(this.sessionHandle); + columnsReq.CatalogName = catalogPattern; + columnsReq.SchemaName = dbSchemaPattern; + columnsReq.TableName = tableNamePattern; + + if (!string.IsNullOrEmpty(columnNamePattern)) + columnsReq.ColumnName = columnNamePattern; + + var columnsResponse = this.client.GetColumns(columnsReq).Result; + if (columnsResponse.Status.StatusCode == TStatusCode.ERROR_STATUS) + { + throw new Exception(columnsResponse.Status.ErrorMessage); + } + + this.operationHandle = columnsResponse.OperationHandle; + } + + PollForResponse(); + + Schema schema = GetSchema(); + + return new GetObjectsReader(this,schema); + } + + public override IArrowArrayStream GetInfo(List<int> codes) + { + throw new NotImplementedException(); + } + + public override IArrowArrayStream GetTableTypes() + { + throw new NotImplementedException(); + } + + protected void PollForResponse() + { + TGetOperationStatusResp statusResponse = null; + do + { + if (statusResponse != null) { Thread.Sleep(500); } Review Comment: @CurtHagenlocher - I have some private WIP to use `async` as much as possible in this C# implementation. It covers end-to-end async support for `ExecuteQueryAsync`/`ExecuteUpdateAsync`. I've put it to side to work on the GetObjects implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
