rok commented on code in PR #13901: URL: https://github.com/apache/arrow/pull/13901#discussion_r1567784002
########## cpp/src/arrow/extension/CMakeLists.txt: ########## @@ -15,10 +15,19 @@ # specific language governing permissions and limitations # under the License. -add_arrow_test(test - SOURCES - fixed_shape_tensor_test.cc - PREFIX - "arrow-fixed-shape-tensor") +if(ARROW_JSON) + add_arrow_test(test + SOURCES + fixed_shape_tensor_test.cc + json_test.cc + PREFIX + "arrow-canonical-extensions") +else() + add_arrow_test(test + SOURCES + json_test.cc Review Comment: `fixed_shape_tensor` requires rapidjson. I'm actually not sure if `ARROW_JSON` controls if rapidjson gets linked or not, will test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
