pitrou commented on a change in pull request #9519: URL: https://github.com/apache/arrow/pull/9519#discussion_r578279748
########## File path: cpp/src/arrow/vendored/ProducerConsumerQueue.h ########## @@ -0,0 +1,211 @@ +// Vendored from git tag v2021.02.15.00 + +/* + * Copyright (c) Facebook, Inc. and its affiliates. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// @author Bo Hu (b...@fb.com) +// @author Jordan DeLong (delon...@fb.com) + +#pragma once + +#include <atomic> +#include <cassert> +#include <cstdlib> +#include <memory> +#include <stdexcept> +#include <type_traits> +#include <utility> + +namespace folly { Review comment: I'm not sure how we want to go about this, but often we try to enclose vendored code in an additional `arrow_vendored` namespace (because when Arrow C++ is used as a library, there may be otherwise be symbol clashes with other uses of Folly by the application - which is very bad if they use a different version of Folly). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
