alamb commented on a change in pull request #9527:
URL: https://github.com/apache/arrow/pull/9527#discussion_r578500826
##########
File path: rust/datafusion/src/physical_plan/parquet.rs
##########
@@ -611,7 +611,7 @@ fn build_predicate_expression(
let max_column_expr = expr_builder.max_column_expr()?;
min_column_expr
.lt_eq(expr_builder.scalar_expr().clone())
- .and(expr_builder.scalar_expr().lt_eq(max_column_expr))
+ .and(expr_builder.scalar_expr().clone().lt_eq(max_column_expr))
Review comment:
this is the only change where the caller had to do an extra clone (and
in this case it was actually needed as `scalar_expr()` is used twice. In other
locations the expr was ignored and this can be consumed without issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
