parthchandra commented on code in PR #255: URL: https://github.com/apache/arrow-datafusion-comet/pull/255#discussion_r1571698298
########## spark/inspections/CometTPCHQueriesList-results.txt: ########## @@ -0,0 +1,121 @@ +Query: q1 TPCH Snappy. Comet Exec: Enabled (CometHashAggregate, CometProject) +Query: q1 TPCH Snappy: ExplainInfo: +Shuffle: unsupported Spark partitioning: org.apache.spark.sql.catalyst.plans.physical.RangePartitioning + +Query: q2 TPCH Snappy. Comet Exec: Enabled (CometSort, CometSortMergeJoin, CometProject, CometFilter) +Query: q2 TPCH Snappy: ExplainInfo: +ObjectHashAggregate is not supported +might_contain is not supported +BroadcastHashJoin is not supported +SortMergeJoin is not supported Review Comment: Another good catch! I reviewed everything and found a few more paths where the error was not being caught. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
