comphead commented on code in PR #10141:
URL:
https://github.com/apache/arrow-datafusion/pull/10141#discussion_r1572603264
##########
datafusion/execution/src/config.rs:
##########
@@ -157,30 +157,34 @@ impl SessionConfig {
}
/// Set a configuration option
- pub fn set(mut self, key: &str, value: ScalarValue) -> Self {
- self.options.set(key, &value.to_string()).unwrap();
- self
+ pub fn set(self, key: &str, value: ScalarValue) -> Self {
Review Comment:
I would still let this method to insert into options, but since we have type
specific methods, this method can probably be a helper and be not public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
