cocoa-xu commented on code in PR #1722: URL: https://github.com/apache/arrow-adbc/pull/1722#discussion_r1573181210
########## go/adbc/driver/bigquery/driver.go: ########## @@ -0,0 +1,222 @@ +package bigquery + +import ( + "cloud.google.com/go/bigquery" + "fmt" + "github.com/apache/arrow-adbc/go/adbc" + "github.com/apache/arrow-adbc/go/adbc/driver/internal/driverbase" + "github.com/apache/arrow/go/v16/arrow/memory" + "golang.org/x/exp/maps" Review Comment: > Sorry it was similar to the snowflake implementation -- `maps.Clone` was used in `NewDatabase` so the `opts` is copied before passing to `db.SetOptions`. I wasn't sure if we need to copy that but I later decided to keep it. I'll remove it. ########## go/adbc/driver/bigquery/driver.go: ########## @@ -0,0 +1,222 @@ +package bigquery + +import ( + "cloud.google.com/go/bigquery" + "fmt" + "github.com/apache/arrow-adbc/go/adbc" + "github.com/apache/arrow-adbc/go/adbc/driver/internal/driverbase" + "github.com/apache/arrow/go/v16/arrow/memory" + "golang.org/x/exp/maps" Review Comment: > Sorry it was similar to the snowflake implementation -- `maps.Clone` was used in `NewDatabase` so the `opts` is copied before passing to `db.SetOptions`. I wasn't sure if we need to copy that but I later decided to keep it. I'll remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
