tustvold commented on code in PR #5671: URL: https://github.com/apache/arrow-rs/pull/5671#discussion_r1573459119
########## arrow-schema/src/datatype.rs: ########## @@ -688,6 +688,32 @@ pub const DECIMAL256_MAX_SCALE: i8 = 76; /// values pub const DECIMAL_DEFAULT_SCALE: i8 = 10; +// used for <https://github.com/apache/arrow-rs/pull/5605> we should decide what two different +// Datatype could be reinterpret +pub fn can_reinterpret(from_type: &DataType, to_type: &DataType) -> bool { Review Comment: This appears to be duplicating the existing logic for schema jnference using the arrow schema as a hint, I'm not sure why we need this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
