wgtmac commented on code in PR #34164:
URL: https://github.com/apache/arrow/pull/34164#discussion_r1573485269
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4446,7 +4446,9 @@ macro(build_orc)
"-DPROTOBUF_LIBRARY=${ORC_PROTOBUF_LIBRARY}"
"-DPROTOC_LIBRARY=${ORC_PROTOBUF_LIBRARY}"
"-DLZ4_HOME=${ORC_LZ4_ROOT}"
- "-DZSTD_HOME=${ORZ_ZSTD_ROOT}")
+ "-DZSTD_HOME=${ORC_ZSTD_ROOT}"
+
"-DZSTD_INCLUDE_DIR=$<TARGET_PROPERTY:${ARROW_ZSTD_LIBZSTD},INTERFACE_INCLUDE_DIRECTORIES>"
Review Comment:
Thanks for the explanation! I will restart the work on the ORC side after I
have finished reading all the CMake code on the Arrow side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
