tustvold commented on code in PR #5672:
URL: https://github.com/apache/arrow-rs/pull/5672#discussion_r1573749060
##########
arrow-ord/src/sort.rs:
##########
@@ -725,16 +726,19 @@ impl LexicographicalComparator {
None => (true, true),
};
+ // TODO: after dict values with nulls are supported, we can
compare with
Review Comment:
I think this will probably be necessary to avoid this change regressing the
performance of lexsort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
