kou commented on PR #41111: URL: https://github.com/apache/arrow/pull/41111#issuecomment-2068485191
Hmm. It seems that `[[maybe_unused]]` doesn't work g++ 8.5.0: https://github.com/ursacomputing/crossbow/actions/runs/8772764647/job/24072078525#step:6:167 ```text -- The CXX compiler identification is GNU 8.5.0 ``` https://github.com/ursacomputing/crossbow/actions/runs/8772764647/job/24072078525#step:6:1075 ```text FAILED: src/arrow/CMakeFiles/arrow_array.dir/array/array_run_end.cc.o /usr/bin/c++ -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_WITH_TIMING_TESTS -I/tmp/arrow-HEAD.P3upj/cpp-build/src -I/arrow/cpp/src -I/arrow/cpp/src/generated -Wno-noexcept-type -fdiagnostics-color=always -Wall -fno-semantic-interposition -msse4.2 -O3 -DNDEBUG -O2 -ftree-vectorize -std=c++17 -fPIC -MD -MT src/arrow/CMakeFiles/arrow_array.dir/array/array_run_end.cc.o -MF src/arrow/CMakeFiles/arrow_array.dir/array/array_run_end.cc.o.d -o src/arrow/CMakeFiles/arrow_array.dir/array/array_run_end.cc.o -c /arrow/cpp/src/arrow/array/array_run_end.cc In file included from /arrow/cpp/src/arrow/array/array_run_end.cc:19: /arrow/cpp/src/arrow/array/builder_primitive.h:38:24: error: expected unqualified-id before '[' token explicit NullBuilder([[maybe_unused]] const std::shared_ptr<DataType>& type, ^ /arrow/cpp/src/arrow/array/builder_primitive.h:38:24: error: expected ')' before '[' token explicit NullBuilder([[maybe_unused]] const std::shared_ptr<DataType>& type, ~^ ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
