zanmato1984 commented on code in PR #41330:
URL: https://github.com/apache/arrow/pull/41330#discussion_r1574249283
##########
cpp/src/gandiva/cache.h:
##########
@@ -25,6 +25,13 @@
namespace gandiva {
+namespace internal {
+// Only called once by GetCapacity().
+// Do the actual work of getting the capacity from env var.
+// Also makes the testing easier.
Review Comment:
It is not possible in google test to re-initialize a static variable. So
have this dedicated function to do the actual work eagerly, then we can test it
instead of `GetCapacity` (which contains the static variable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
