tustvold commented on code in PR #5670:
URL: https://github.com/apache/arrow-rs/pull/5670#discussion_r1574503228
##########
arrow-array/src/ffi_stream.rs:
##########
@@ -63,14 +63,16 @@ use std::{
sync::Arc,
};
+use arrow_data::ffi::FFI_ArrowArray;
+use arrow_schema::{ffi::FFI_ArrowSchema, ArrowError, Schema, SchemaRef};
+
use crate::array::Array;
use crate::array::StructArray;
-use crate::datatypes::{Schema, SchemaRef};
-use crate::error::ArrowError;
-use crate::error::Result;
-use crate::ffi::*;
+use crate::ffi::from_ffi_and_data_type;
use crate::record_batch::{RecordBatch, RecordBatchReader};
+type Result<T> = std::result::Result<T, ArrowError>; // TODO(alexandreyc): we
should probably move Result to arrow_schema
Review Comment:
I had feedback from some people that overloading Result was confusing, I
happen to think it reduces code verbosity and quite like it, but that's the
history of why it didn't get moved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
