mbrobbel commented on code in PR #1742:
URL: https://github.com/apache/arrow-adbc/pull/1742#discussion_r1574573423
##########
rust/core/src/ffi/mod.rs:
##########
@@ -16,11 +16,22 @@
// under the License.
pub mod constants;
+pub(crate) mod methods;
pub(crate) mod types;
+pub use types::{
+ FFI_AdbcConnection, FFI_AdbcDatabase, FFI_AdbcDriver,
FFI_AdbcDriverInitFunc, FFI_AdbcError,
+ FFI_AdbcErrorDetail, FFI_AdbcPartitions, FFI_AdbcStatement,
FFI_AdbcStatusCode,
Review Comment:
Following `arrow-rs` makes sense. Generally I prefer following the API
guidelines https://rust-lang.github.io/api-guidelines/naming.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
