istvan-fodor commented on code in PR #5666:
URL: https://github.com/apache/arrow-rs/pull/5666#discussion_r1574835054
##########
arrow-flight/examples/flight_sql_server.rs:
##########
@@ -999,15 +1028,6 @@ mod tests {
.to_string()
.contains("Invalid credentials"));
- // forget to set_token
- client.handshake("admin", "password").await.unwrap();
- assert!(client
- .prepare("select 1;".to_string(), None)
- .await
- .unwrap_err()
- .to_string()
- .contains("No authorization header"));
Review Comment:
Correct, because the headers is not set on the server response, this call
actually succeeds now. In the updated code now we have this:
```rust
// Successful call (token is automatically set by handshake)
client.handshake("admin", "password").await.unwrap();
client.prepare("select 1;".to_string(), None).await.unwrap();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
