paleolimbot commented on code in PR #442: URL: https://github.com/apache/arrow-nanoarrow/pull/442#discussion_r1576172583
########## python/set_dev_version.py: ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Set development version from git + +This is used to set the Python package version before building +nightly wheels, since at least some tools do not allow +duplicate versions when uploading sdist/wheels. This requires +that the repo has a full checkout with tags. + +The Python package version is hard-coded in a _static_version.py Review Comment: When I set this up I tried that, and while I forget the details, I remember that it was somewhat difficult in practice to satisfy all the constraints. I think one of the main pieces was ensuring that the wheels were built with the release version as part of the RC process (i.e., before the tag is actually created but after the versions have been bumped). I'm sure it's possible to do, but the static version string fits better with the other version bumpers (until now!). Probably it would be better to move this to dev/release (with the rest of the version bumpers) so that this doesn't stick out quite as much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
