lidavidm commented on PR #1738: URL: https://github.com/apache/arrow-adbc/pull/1738#issuecomment-2073697782
We expect a catalog, schema, and table _name_, and as others have chimed in above this is typical of database APIs. If Snowflake's quoting rules mean that the _SQL identifier_ `dummy` results in the _name_ `DUMMY`, then we expect the latter. It happened to work before because we were just concatenating SQL strings internally, but this does not work for all drivers and all users - for instance, Flight SQL now has an ingestion API that works on names and not SQL identifiers. And, not all users are using sqlglot to escape names for them, nor would we expect or require them to do so; hence why these APIs all work on names. I'd be supportive of a Snowflake driver-specific option to disable this at the user's own risk, but for the purposes of this PR let's fix the quoting first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
