mapleFU commented on PR #41320: URL: https://github.com/apache/arrow/pull/41320#issuecomment-2075193327
> not sure in which direction: your above proposal " // Check all columns has same row-size" or the alternative proposal I made in https://github.com/apache/arrow/pull/41320#issuecomment-2068064220 using Validate() ? I'm happy if you follow up with another PR in the direction you prefer. I mean we can check it here: https://github.com/apache/arrow/pull/41320#pullrequestreview-2019926584 . After this, Error would be raise if column number mismatches. Other can be `ARROW_DCHECK`. > I would argue that libarrow/libparquet should be robust against hostile/corrupted datasets even on Release builds, as those kind of crashes are undesirable, and may potentially have security implications. Yeah. I only malform table is the root (see https://github.com/apache/arrow/issues/41317#issuecomment-2074947638 ) cause of this memory access, other can just be debug checkings. `::arrow::Table::Validate` is also ok but it might be a bit heavy than required. It's also ok for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
